Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: value error recherche prestataire => passage django 4.2 => 5.1 #1635

Open
wants to merge 1,518 commits into
base: master
Choose a base branch
from
Open

fix: value error recherche prestataire => passage django 4.2 => 5.1 #1635

wants to merge 1,518 commits into from

Conversation

Guilouf
Copy link
Collaborator

@Guilouf Guilouf commented Jan 15, 2025 •
edited
Loading

Quoi ?

Erreur 500 à cause de caractères nulls: http://localhost:8000/prestataires/?sectors=1%00%EF%BF%BD%EF%BF%BD%EF%BF%BD%EF%BF%BD%252527%252522

Pourquoi ?

C'est un bug django https://code.djangoproject.com/ticket/35483 qui a été patché en version 5.1 django/django@38ad710

Comment ?

Une bonne occasion de passer en version 5 ?

madjid-asa and others added 30 commits February 29, 2024 18:04
@madjid-asa
feat(admin_tenders): Rediriger vers la section structures après la va…
182bffc 
…lidation des DDB (#1111)

* add id html to Django admin template

* redirect to structures after save

* add comment to explain
@raphodn
fix(SIAE): Evite que le champ is_delisted soit écrasé à chaque synchr…
cd87cfc 
…o avec les emplois (#1108)
@raphodn
feat(SIAE): nouvelle property is_live (#1107)
37acc19
@raphodn
fix(Admin): Besoins : répare le filtre par montant exact (#1112)
8f236a5
@SebastienReuiller
feat(Besoins): Ajout d'un filtre par type de besoin (#1104)
66498d1
@madjid-asa
feat(Dashboard SIAE): Réordonner les besoins (derniers publiés en pre…
4bf23fa 
…mier) (#1098)
@raphodn
fix(Admin): Besoins: ajuste les règles de filtrage pour le montant ex…
8464a4a 
…act. ref #1112
@raphodn
fix(CI): affiche mieux les diff dans le script de déploiement. ref #1063
07945b1
@raphodn
feat(Besoins): Nouveau champ M2M 'admins' pour aider le suivi (#1113)
4805481
@raphodn
feat(Besoins): nouveau champ pour stocker la date de transaction (#1116)
eb9ba37
@raphodn
feat(Admin): Secteurs : afficher le nombre de besoins concernés (#1118)
d64cd05
@raphodn
feat(Besoins): Permettre à une structure contactée de décliner dès l'…
f689995 
…e-mail (#1114)
@raphodn
feat(Besoins): Admin : Connaitre le nombre de besoins déposés par cha…
9bdb17e 
…que entreprise (#1120)
@madjid-asa
refactor: Améliorer le badge de clôture du DDB (#1095)
6130462
@SebastienReuiller
feat(Besoins): Mesure du NPS des acheteurs (#1119)
41a6a2d
@SebastienReuiller
feat(Besoins): Ajout du nombre d'occurences en status Nouveau sur le …
2eb13a6 
…filtre par type (#1117)
@raphodn
feat(Besoins): Admin : Avoir le status de la mise en relation (#1121)
9ee602c
@raphodn
feat(Besoins): mettre à jour automatiquement la date de transaction (#…
ee9723a 
…1122)
@raphodn
feat(SIAE): script pour aider le rattachement à leur réseau (grâce à …
6c7d4e7 
…des import csv) (#1109)
@raphodn
feat(Besoins): Connaitre la source de la transaction (#1124)
361b215
@raphodn
fix: on TenderSiae survey_transaction answer, only update Tender if T…
3cd9886 
…rue. ref #1124
@madjid-asa
feat(Dépôt de besoins): Permettre aux structures de supprimer les dép…
97ca704 
…ôts de besoins expirés (#1110)
@madjid-asa
fix(Dépôt de besoin): Réparation du badge de clôture (#1125)
994dbed
@madjid-asa
fix: Affichage du header droit de la liste des dépôt de besoins (#1128)
4bdc0d6
@raphodn
fix(API): mise à jour du lien vers api.gouv (#1127)
c11427e
@SebastienReuiller
fix(Besoins): Correction sur le nombre d'occurrences en status Nouvea…
a8617a6 
…u sur le filtre par type (#1126)
@raphodn
fix(APProch): Améliore le wording du bouton CTA des besoins provenant…
72960ea 
… d'APProch. ref #923
@raphodn
fix(API): Exclure les structures OPCS des résultats (#1129)
15276c6
@raphodn
refactor(API): small siae queryset optimization. ref #1129
33afeb3
@raphodn
fix(Besoins): Exclure les structures OPCS du matching (#1130)
6befb16
@Guilouf Guilouf added the bug Something isn't working label Jan 15, 2025
@Guilouf Guilouf self-assigned this Jan 15, 2025
@Guilouf Guilouf changed the title Fix useless comment fix: value error recherche prestataire Jan 15, 2025
@Guilouf Guilouf marked this pull request as ready for review January 15, 2025 16:31
@Guilouf Guilouf changed the title fix: value error recherche prestataire fix: value error recherche prestataire => passage django 4.2 => 5.1 Jan 15, 2025
@madjid-asa madjid-asa force-pushed the guilouf/value-error-prestataires branch from 34491dc to 1ac487f Compare February 4, 2025 21:25
@gitguardian GitGuardian
Copy link

gitguardian bot commented Feb 4, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13853755 Triggered Generic High Entropy Secret 412e041 config/settings/base.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 4, 2025
View reviewed changes
lemarche/static/js/favorite_item.js Dismissed Show dismissed Hide dismissed
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 4, 2025
View reviewed changes
lemarche/siaes/management/commands/import_esat_from_asp.py Dismissed Show dismissed Hide dismissed
lemarche/siaes/management/commands/import_esat_from_asp.py Dismissed Show dismissed Hide dismissed
lemarche/siaes/management/commands/import_esat_from_csv.py Dismissed Show dismissed Hide dismissed
lemarche/siaes/management/commands/import_esat_gesat.py Dismissed Show dismissed Hide dismissed
lemarche/siaes/management/commands/import_esat_handeco.py Dismissed Show dismissed Hide dismissed
lemarche/siaes/management/commands/import_sep.py Dismissed Show dismissed Hide dismissed
lemarche/www/auth/views.py Dismissed Show dismissed Hide dismissed
lemarche/www/siaes/views.py Dismissed Show dismissed Hide dismissed
lemarche/www/siaes/views.py Dismissed Show dismissed Hide dismissed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chloend chloend Awaiting requested review from chloend

@madjid-asa madjid-asa Awaiting requested review from madjid-asa

@SebastienReuiller SebastienReuiller Awaiting requested review from SebastienReuiller

At least 1 approving review is required to merge this pull request.

Assignees

@Guilouf Guilouf

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Guilouf @madjid-asa @raphodn @SebastienReuiller @vperron @chloend